XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.48k stars 1.45k forks source link

Price oracle get aggregation method doesn't resolve the request back when trim is set to 50 or higher number #4912

Open manojsdoshi opened 4 months ago

manojsdoshi commented 4 months ago

Request trim value 49:

{ "method": "get_aggregate_price", "params": [ { "ledger_index": "current", "base_asset": "XRP", "quote_asset": "USD", "trim": 49, "oracles": [ { "account": "rM3jvPTYjqhMVeh2XwwEg2BFa6nEhvmenU", "oracle_document_id": 100 }, { "account": "rJmYPVptXTvsrAjsjmMHr9TnorrZhnv47z", "oracle_document_id": 100 } ] } ] }

Response trim value 49:

{ "result": { "entire_set": { "mean": "74", "size": 2, "standard_deviation": "0" }, "ledger_current_index": 37651, "median": "74", "status": "success", "time": 1705975695, "trimmed_set": { "mean": "74", "size": 2, "standard_deviation": "0" }, "validated": false } }

Request trim value 50:

{ "method": "get_aggregate_price", "params": [ { "ledger_index": "current", "base_asset": "XRP", "quote_asset": "USD", "trim": 50, "oracles": [ { "account": "rM3jvPTYjqhMVeh2XwwEg2BFa6nEhvmenU", "oracle_document_id": 100 }, { "account": "rJmYPVptXTvsrAjsjmMHr9TnorrZhnv47z", "oracle_document_id": 100 } ] } ] }

Response trim value 50:

{ "result": { "error": "internal", "error_code": 73, "error_message": "Internal error.", "request": { "base_asset": "XRP", "command": "get_aggregate_price", "ledger_index": "current", "oracles": [ { "account": "rM3jvPTYjqhMVeh2XwwEg2BFa6nEhvmenU", "oracle_document_id": 100 }, { "account": "rJmYPVptXTvsrAjsjmMHr9TnorrZhnv47z", "oracle_document_id": 100 } ], "quote_asset": "USD", "trim": 50 }, "status": "error" } }

And anything above 100 doesn't resolve in a response back and the memory usage of rippled goes higher

gregtatcam commented 4 months ago

Have you tried with the latest patch?

manojsdoshi commented 4 months ago

I haven't tried your latest fix yet @gregtatcam will try and close it out if it's working.