Fix gcc 13 compile error in Price Oracle unit-test

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++

https://xrpl.org

ISC License

4.48k stars 1.45k forks source link

Fix gcc 13 compile error in Price Oracle unit-test #4932

Closed gregtatcam closed 4 months ago

gregtatcam commented 4 months ago

High Level Overview of Change

This fix addresses a compile error on Ubuntu gcc 13 and higher.

Context of Change

The bug was introduced within the Price Oracle feature, specifically in the rpc unit-test GetAggregatePrice. The compilation fails due to an issue in the initializer list of an optional argument, which holds a vector of pairs.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Performance (increase or change in throughput and/or latency)
[ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation update
[ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
[ ] Release

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.61%. Comparing base (e718378) to head (b353d56).

:exclamation: Current head b353d56 differs from pull request most recent head 0929e49. Consider uploading reports for the commit 0929e49 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #4932 +/- ## =========================================== + Coverage 61.58% 61.61% +0.03% =========================================== Files 804 804 Lines 70640 70641 +1 Branches 36534 36534 =========================================== + Hits 43502 43525 +23 + Misses 19836 19806 -30 - Partials 7302 7310 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

manojsdoshi commented 4 months ago

unsubscribe

On Tue, Feb 27, 2024 at 5:10 AM Scott Determan @.***> wrote:

@.**** approved this pull request.

Confirmed this fixes the issue

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4932*pullrequestreview-1903325912__;Iw!!PZTMFYE!97qqc7zhdvlf0AgrWqMIxd7QsVgTBJQ1ctSFgDmNm5YGccuW-xgD6rArFyHjLLjk-xA1LLsAHS4LcNOG0RTXcw$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABFOYZOGJIQWC3UPJHZLIYLYVXELBAVCNFSM6AAAAABD3UYAOSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBTGMZDKOJRGI__;!!PZTMFYE!97qqc7zhdvlf0AgrWqMIxd7QsVgTBJQ1ctSFgDmNm5YGccuW-xgD6rArFyHjLLjk-xA1LLsAHS4LcNMgWV0Zvw$ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

gregtatcam commented 4 months ago

Proposed commit message:

This fix addresses a compile error on Ubuntu gcc 13 and higher:

The error was introduced within the Price Oracle feature, specifically in the rpc unit-test GetAggregatePrice. The compilation fails due to an issue in the initializer list of an optional argument, which holds a vector of pairs. The compilation error only occurs on Ubuntu gcc 13 and higher.