XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.51k stars 1.46k forks source link

Add STCurrency.h to xrpl_core to fix clio build #4939

Closed gregtatcam closed 6 months ago

gregtatcam commented 6 months ago

High Level Overview of Change

Fixes clio build.

Context of Change

Adds STCurrency.h to RippledCore.cmake.

Type of Change

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.65%. Comparing base (22b7518) to head (650245d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4939 +/- ## ======================================== Coverage 61.65% 61.65% ======================================== Files 806 806 Lines 70967 70967 Branches 36690 36690 ======================================== Hits 43752 43752 + Misses 19856 19855 -1 - Partials 7359 7360 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

legleux commented 6 months ago

Looks good to me in terms of fixing Clio 👍

@thejohnfreeman @legleux you mentioned something more needed to be done I believe?

Just that I had a PR that moved a bunch of of headers so I'd just add this with that PR #4940.