XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.48k stars 1.45k forks source link

[TRIVIAL] chore: Default validator-keys-tool to build from master branch #4943

Closed ximinez closed 2 months ago

ximinez commented 3 months ago

High Level Overview of Change

master is the default branch for that project. There's no point in using develop.

Context of Change

https://github.com/ripple/validator-keys-tool/pull/40#issuecomment-1984374109

I just rebased develop onto master. After resolving conflicts, the branches were identical.

If there are no objections, I'm going to close this PR and force push that updated develop.

I think the correct solution is to update the check in rippled to default to use the master branch, and delete this develop branch entirely.

Type of Change

Before / After

These changes only matter when building https://github.com/ripple/validator-keys-tool from within the rippled repo. e.g.

git checkout develop
cmake -Dvalidator-keys=ON [...] <build dir>
cmake --build <build dir> --target validator-keys

Before:

If building from any rippled branch other than master or release, validator-keys will be built from its develop branch.

After:

If building from any rippled branch other than release, validator-keys will be built from its master branch.

Future Tasks

If this PR is merged, the develop branch can be deleted from https://github.com/ripple/validator-keys-tool.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.96%. Comparing base (bcbf6c1) to head (6f15a27).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4943 +/- ## =========================================== - Coverage 76.97% 76.96% -0.01% =========================================== Files 1129 1129 Lines 131916 131913 -3 Branches 39614 39647 +33 =========================================== - Hits 101537 101528 -9 - Misses 24435 24483 +48 + Partials 5944 5902 -42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.