search

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.51k stars 1.46k forks source link

Embed patched recipe for RocksDB 6.29.5 #4947

Closed thejohnfreeman closed 6 months ago

thejohnfreeman commented 6 months ago

We depend on RocksDB 6.29.5. I don't know how we ever built a working package for it with MSVC, but when we removed it from the Ripple cache recently, CI could not build its replacement. This PR copies the recipe from Conan Center and adds a small patch to remove the statement include(thirdparty.inc) from its CMakeLists.txt, which fixes the build.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.65%. Comparing base (c28e005) to head (58eafe1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4947 +/- ## ======================================== Coverage 61.64% 61.65% ======================================== Files 806 806 Lines 70967 70967 Branches 36690 36690 ======================================== + Hits 43745 43752 +7 + Misses 19865 19856 -9 - Partials 7357 7359 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.