search

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.51k stars 1.46k forks source link

Fix workflows #4948

Closed thejohnfreeman closed 6 months ago

thejohnfreeman commented 6 months ago

The problem was CONAN_USERNAME environment variable, which Conan 1.x uses as the default user in package references.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.81%. Comparing base (22b7518) to head (51d1bf4). Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4948 +/- ## ============================================ + Coverage 61.65% 76.81% +15.16% ============================================ Files 806 1128 +322 Lines 70967 132058 +61091 Branches 36690 39582 +2892 ============================================ + Hits 43752 101443 +57691 - Misses 19856 24648 +4792 + Partials 7359 5967 -1392 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Bronek commented 6 months ago

What's the purpose of CONAN_PASSWORD_RIPPLE and CONAN_LOGIN_USERNAME_RIPPLE ?

BTW I do understand that it is perfectly normal for an action to implicitly use environment variables. It's the _RIPPLE suffix which makes it confusing, because one possible use of such a suffix is to prevent such an implicit use of an environment variable.