XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.51k stars 1.46k forks source link

Proposed 2.2.0-b2 #4979

Closed ximinez closed 5 months ago

ximinez commented 5 months ago

High Level Overview of Change

This is a beta for the 2.2.0 release.

Highlights:

The base branch is release. All releases (including betas) go in release. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to both release and develop.

Context of Change

This introduces

It also fixes up some technical debt and build issues, and fixes the 'install' target so that downstream projects like clio can build properly.

Type of Change

API Impact

No API impact.

Bronek commented 5 months ago

Important caveat - because of https://github.com/XRPLF/rippled/pull/4893 , we have added a conan dependency on xxHash::xxhash xxhash::xxhash, which is transitive for users of libxrpl . We could hide this dependency if we think it's a problem - i.e. move implementation of class xxhasher from header to .cpp so the dependency #include <xxhash.h> does not show up in header file xxhasher.hpp (which is seen in the library interface)

ximinez commented 5 months ago

@Bronek What is the worst case for users of libxrpl once they bump their dependency to this version or later? I assume they'd have to re-run conan install. Maybe wipe out their build directory?

Bronek commented 5 months ago

@Bronek What is the worst case for users of libxrpl once they bump their dependency to this version or later? I assume they'd have to re-run conan install. Maybe wipe out their build directory?

re-running conan install will be definitely needed; luckily it does not rebuild anything that's already in conan cache, so it should be quick, no need to wipe anytihing. The bigger problem is for projects which depend in libxrpl, as they will also (transitively) gain this dependency, without necessarily knowing about it. So they will also have to re-run conan install

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 85.93172% with 342 lines in your changes are missing coverage. Please review.

Project coverage is 76.96%. Comparing base (d7d15a9) to head (c88166e). Report is 3 commits behind head on release.

Files Patch % Lines
src/test/basics/base58_test.cpp 80.20% 29 Missing and 10 partials :warning:
src/ripple/rpc/handlers/GetAggregatePrice.cpp 82.71% 13 Missing and 15 partials :warning:
src/ripple/app/tx/impl/SetOracle.cpp 85.00% 9 Missing and 15 partials :warning:
src/ripple/protocol/impl/token_errors.h 17.24% 24 Missing :warning:
src/ripple/protocol/impl/tokens.cpp 89.32% 9 Missing and 10 partials :warning:
src/ripple/app/tx/impl/DeleteOracle.cpp 55.00% 11 Missing and 7 partials :warning:
src/test/jtx/impl/Oracle.cpp 88.38% 12 Missing and 6 partials :warning:
src/ripple/app/paths/impl/AMMOffer.cpp 40.74% 15 Missing and 1 partial :warning:
src/ripple/protocol/impl/b58_utils.h 78.78% 6 Missing and 8 partials :warning:
src/ripple/rpc/handlers/LedgerEntry.cpp 58.62% 8 Missing and 4 partials :warning:
... and 32 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release #4979 +/- ## ============================================ + Coverage 61.53% 76.96% +15.43% ============================================ Files 797 1129 +332 Lines 70158 131913 +61755 Branches 36261 39628 +3367 ============================================ + Hits 43170 101527 +58357 - Misses 19753 24464 +4711 + Partials 7235 5922 -1313 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.