Closed ximinez closed 5 months ago
Important caveat - because of https://github.com/XRPLF/rippled/pull/4893 , we have added a conan dependency on
xxHash::xxhash xxhash::xxhash
, which is transitive for users of libxrpl
. We could hide this dependency if we think it's a problem - i.e. move implementation of class xxhasher
from header to .cpp
so the dependency #include <xxhash.h>
does not show up in header file xxhasher.hpp
(which is seen in the library interface)
@Bronek What is the worst case for users of libxrpl
once they bump their dependency to this version or later? I assume they'd have to re-run conan install
. Maybe wipe out their build directory?
@Bronek What is the worst case for users of
libxrpl
once they bump their dependency to this version or later? I assume they'd have to re-runconan install
. Maybe wipe out their build directory?
re-running conan install
will be definitely needed; luckily it does not rebuild anything that's already in conan cache, so it should be quick, no need to wipe anytihing. The bigger problem is for projects which depend in libxrpl
, as they will also (transitively) gain this dependency, without necessarily knowing about it. So they will also have to re-run conan install
Attention: Patch coverage is 85.93172%
with 342 lines
in your changes are missing coverage. Please review.
Project coverage is 76.96%. Comparing base (
d7d15a9
) to head (c88166e
). Report is 3 commits behind head on release.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
High Level Overview of Change
This is a beta for the 2.2.0 release.
Highlights:
4327
4781
4950
4763
4933
The base branch is
release
. All releases (including betas) go inrelease
. This PR will be merged with--ff-only
(not squashed or rebased, and not using the GitHub UI) to bothrelease
anddevelop
.Context of Change
This introduces
feature
RPC command, allowing lookups without changing voting settingsfixEmptyDID
amendment to prevent creation of empty DID objectsfixXChainRewardRounding
amendment to improve the calculation of reward sharesIt also fixes up some technical debt and build issues, and fixes the 'install' target so that downstream projects like
clio
can build properly.Type of Change
API Impact
No API impact.