search

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.51k stars 1.46k forks source link

Proposed 2.2.0-b3 #4995

Closed ximinez closed 5 months ago

ximinez commented 5 months ago

High Level Overview of Change

This is a beta for the 2.2.0 release.

Highlights:

The base branch is release. All releases (including betas) go in release. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to both release and develop.

Context of Change

This introduces

It also fixes a deadlock situation during online_delete, improved code coverage reporting, and adds several tests to improve coverage of AMM functionality.

Type of Change

API Impact

No API impact.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.0%. Comparing base (c88166e) to head (676aae2).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/4995/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## release #4995 +/- ## ========================================== - Coverage 77.0% 71.0% -6.0% ========================================== Files 1129 796 -333 Lines 131914 66727 -65187 Branches 39629 10971 -28658 ========================================== - Hits 101539 47348 -54191 + Misses 24459 19379 -5080 + Partials 5916 0 -5916 ``` | [Files](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [src/ripple/app/misc/impl/AMMUtils.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Fmisc%2Fimpl%2FAMMUtils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvbWlzYy9pbXBsL0FNTVV0aWxzLmNwcA==) | `99.2% <ø> (+24.0%)` | :arrow_up: | | [src/ripple/app/paths/AMMOffer.h](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Fpaths%2FAMMOffer.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvcGF0aHMvQU1NT2ZmZXIuaA==) | `83.3% <ø> (ø)` | | | [src/ripple/app/paths/impl/AMMOffer.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Fpaths%2Fimpl%2FAMMOffer.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvcGF0aHMvaW1wbC9BTU1PZmZlci5jcHA=) | `81.8% <ø> (+23.9%)` | :arrow_up: | | [src/ripple/app/tx/impl/AMMDeposit.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Ftx%2Fimpl%2FAMMDeposit.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvdHgvaW1wbC9BTU1EZXBvc2l0LmNwcA==) | `95.1% <ø> (+16.7%)` | :arrow_up: | | [src/ripple/app/tx/impl/AMMWithdraw.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Ftx%2Fimpl%2FAMMWithdraw.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvdHgvaW1wbC9BTU1XaXRoZHJhdy5jcHA=) | `90.4% <ø> (+15.5%)` | :arrow_up: | | [src/ripple/ledger/impl/ApplyStateTable.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fledger%2Fimpl%2FApplyStateTable.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9sZWRnZXIvaW1wbC9BcHBseVN0YXRlVGFibGUuY3Bw) | `92.6% <100.0%> (+5.7%)` | :arrow_up: | | [src/ripple/nodestore/impl/DatabaseRotatingImp.h](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fnodestore%2Fimpl%2FDatabaseRotatingImp.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9ub2Rlc3RvcmUvaW1wbC9EYXRhYmFzZVJvdGF0aW5nSW1wLmg=) | `50.0% <ø> (ø)` | | | [src/ripple/protocol/Feature.h](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fprotocol%2FFeature.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9wcm90b2NvbC9GZWF0dXJlLmg=) | `100.0% <ø> (+7.9%)` | :arrow_up: | | [src/ripple/protocol/STIssue.h](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fprotocol%2FSTIssue.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9wcm90b2NvbC9TVElzc3VlLmg=) | `80.0% <ø> (+5.0%)` | :arrow_up: | | [src/ripple/protocol/STLedgerEntry.h](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&filepath=src%2Fripple%2Fprotocol%2FSTLedgerEntry.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9wcm90b2NvbC9TVExlZGdlckVudHJ5Lmg=) | `100.0% <ø> (ø)` | | | ... and [6 more](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | | ... and [770 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/4995/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/4995/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/4995?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)