search

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.51k stars 1.46k forks source link

Fix compatibility with Conan 2.x #5001

Closed thejohnfreeman closed 3 months ago

thejohnfreeman commented 5 months ago

This PR makes a few small changes to conanfile.py that make it work with Conan 2.x in my basic testing. I don't think we should recommend 2.x yet. It requires a small change to the conan export instructions, and the conan profile update instructions are completely invalid. Builders will have to manually edit their profiles to make changes. 1.x support is unaffected.

Closes #4926, #4990

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.1%. Comparing base (2df6356) to head (13b15bf).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5001/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5001 +/- ## ========================================= - Coverage 71.1% 71.1% -0.0% ========================================= Files 796 796 Lines 66997 66997 Branches 11005 10980 -25 ========================================= - Hits 47639 47633 -6 - Misses 19358 19364 +6 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5001/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5001/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)