XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.48k stars 1.44k forks source link

`NFTokenOffers` Vector256 is not mapped directly to a specific Hash256 #5005

Open dangell7 opened 2 months ago

dangell7 commented 2 months ago

Issue Description

The Vector256 field NFTokenOffers is mapped to 2 different types of hashes. So its impossible to tell the user during display of the transaction if they are cancelling a Buy offer or a Sell offer.

Going forward lets force all Vector256's to be mapped directly to a single Hash type so its clear to the user what type of Hash is being submitted.

This is causing an issue with Ledger Device integration of XLS20.

Steps to Reproduce

Expected Result

Actual Result

Environment

Supporting Files