XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.48k stars 1.44k forks source link

Remove flow assert: #5009

Closed seelabs closed 1 month ago

seelabs commented 1 month ago

Rounding in the payment engine is causing an assert to sometimes fire with "dust" amounts. This is causing issues when running debug builds of rippled. This issue will be addressed, but the assert is no longer serving its purpose.

Type of Change

Bronek commented 1 month ago

I know it was hard to choose to do this, but I think this is a good choice. Having this assert fire was training me to be dismissive of asserts.

I think as long as we:

... it's fine not to have it