Proposed 2.2.0-rc2

[seelabs]

High Level Overview of Change

This is a release candidate for the 2.2.0 release.

Highlights:

• 5016

• 5013

The base branch is release. All releases (including betas) go in release. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to both release and develop.

Context of Change

This introduces

• the fixAMMv1_1 amendment which fixes several issues with the AMM including: low quality lob offers blocking AMM offers, fixing how transfer fees are handled with the AMM, fixing an issue with an internal function that adjust amounts by lp tokens, and fixing an issue when the lp token balance of the last liquidity provider does not match the LPTokenBalance (due to floating point issues).
• Fixes to the price oracle where some input parameters were not properly validated.
• Misc fixes for conan, missing include files, and updating the CONTRIBUTING file.

It also introduces the first step in a physical code reorganization, unit test utilities to test RPC calls, and a global Rules object for transaction processing.

Type of Change

• [x] Release

API Impact

No API impact.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 93.37979% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 71.1%. Comparing base (02ec8b7) to head (d5e5c3c).

Additional details and impacted files

[](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## release #5018 +/- ## ========================================= + Coverage 70.9% 71.1% +0.2% ========================================= Files 796 796 Lines 66792 66997 +205 Branches 10998 10979 -19 ========================================= + Hits 47378 47633 +255 + Misses 19414 19364 -50 ``` | [Files](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [src/ripple/app/misc/impl/AMMHelpers.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Fmisc%2Fimpl%2FAMMHelpers.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvbWlzYy9pbXBsL0FNTUhlbHBlcnMuY3Bw) | `97.6% <100.0%> (+0.8%)` | :arrow_up: | | [src/ripple/app/misc/impl/AMMUtils.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Fmisc%2Fimpl%2FAMMUtils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvbWlzYy9pbXBsL0FNTVV0aWxzLmNwcA==) | `99.4% <100.0%> (+0.2%)` | :arrow_up: | | [src/ripple/app/paths/impl/StrandFlow.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Fpaths%2Fimpl%2FStrandFlow.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvcGF0aHMvaW1wbC9TdHJhbmRGbG93Lmg=) | `86.1% <ø> (+1.0%)` | :arrow_up: | | [src/ripple/app/tx/impl/AMMCreate.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Ftx%2Fimpl%2FAMMCreate.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvdHgvaW1wbC9BTU1DcmVhdGUuY3Bw) | `90.2% <ø> (ø)` | | | [src/ripple/app/tx/impl/DeleteOracle.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Ftx%2Fimpl%2FDeleteOracle.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvdHgvaW1wbC9EZWxldGVPcmFjbGUuY3Bw) | `100.0% <ø> (+27.5%)` | :arrow_up: | | [src/ripple/app/tx/impl/SetOracle.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Ftx%2Fimpl%2FSetOracle.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvdHgvaW1wbC9TZXRPcmFjbGUuY3Bw) | `100.0% <ø> (+5.6%)` | :arrow_up: | | [src/ripple/basics/Number.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fbasics%2FNumber.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9iYXNpY3MvTnVtYmVyLmg=) | `100.0% <100.0%> (ø)` | | | [src/ripple/conditions/impl/utils.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fconditions%2Fimpl%2Futils.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9jb25kaXRpb25zL2ltcGwvdXRpbHMuaA==) | `69.4% <ø> (ø)` | | | [src/ripple/consensus/LedgerTrie.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fconsensus%2FLedgerTrie.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9jb25zZW5zdXMvTGVkZ2VyVHJpZS5o) | `85.8% <ø> (ø)` | | | [src/ripple/ledger/impl/View.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&filepath=src%2Fripple%2Fledger%2Fimpl%2FView.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9sZWRnZXIvaW1wbC9WaWV3LmNwcA==) | `91.6% <100.0%> (ø)` | | | ... and [10 more](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5018/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [](https://app.codecov.io/gh/XRPLF/rippled/pull/5018?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)