search

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.48k stars 1.44k forks source link

Add `xrpl.libpb` as an exported lib #5022

Closed godexsoft closed 1 month ago

godexsoft commented 1 month ago

High Level Overview of Change

Tiny change to export libpb so that consumers of libxrpl can link against it again.

Context of Change

Clio could not link against libxrpl produced from the current code. The reason seems to be that libpb was not exported and consequently did not make it into the linked libraries despite being publicly linked thru thexrpl::libxrpl target in cmake.

Type of Change

API Impact

None other than being able to link against libxrpl as a consumer.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.1%. Comparing base (f2d37da) to head (9bcfc85).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5022/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5022 +/- ## ======================================= Coverage 71.1% 71.1% ======================================= Files 796 796 Lines 66997 66997 Branches 10980 10978 -2 ======================================= + Hits 47634 47636 +2 + Misses 19363 19361 -2 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5022/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5022/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)