XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.48k stars 1.44k forks source link

Fix gcc-14 build #5025

Closed oleks-rip closed 4 weeks ago

oleks-rip commented 1 month ago

High Level Overview of Change

Fix fstream usage to be compatible with gcc-14

Context of Change

gcc-14 require explicit definition of the fstream classes

Type of Change

API Impact

none

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.05%. Comparing base (c88166e) to head (571e259). Report is 38 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5025 +/- ## ============================================ - Coverage 76.97% 60.05% -16.93% ============================================ Files 1129 806 -323 Lines 131914 67307 -64607 Branches 39629 36826 -2803 ============================================ - Hits 101539 40418 -61121 + Misses 24459 19471 -4988 - Partials 5916 7418 +1502 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Bronek commented 4 weeks ago

Note, this broke both MacOS and Windows build, because of no matching constructor for std::ifstream (and std::ostream) from boost::filesystem::path . Try adding .native() calls.

oleks-rip commented 4 weeks ago

Thank you. I've updated to 2.2.0-rc3 and everything seems ok, without this fix. I'll close it.