XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.48k stars 1.44k forks source link

Upload libXRPL flow #5028

Open godexsoft opened 1 month ago

godexsoft commented 1 month ago

High Level Overview of Change

Adding a workflow that automatically publishes libxrpl to Artifactory and triggers a workflow in Clio's CI using repository_dispatch.

This flow will only run if the BuildInfo.cpp file was updated in a PR for the release branch. Typically this means a new version is proposed.

Publishing the library as soon as possible (i.e. not after merging it or tagging the version) gives us the ability to notify Clio's CI and trigger a full check against the new version of libxrpl. In the future we could automate a notification back from Clio to report whether the checks were successful or not.

This flow will start together with others (if conditions are met) but will not proceed with the upload until essential other checks are done and are either successful or skipped (not cancelled or failed). Currently the essential checks are all dependencies and test running on linux. Mac and Windows are not on the list. Main reason for that is Mac being flaky and we don't want to fail this step (at least not often).

Two secrets that need to be present in the repo (are already present):

And a new one that needs to be added in order to trigger a workflow on Clio's CI:

Please contact me to get the token for this secret.

Here is the flow in Clio CI that does the rest: https://github.com/XRPLF/clio/pull/1433

Context of Change

Recently there was an rc of libxrpl that did not allow consumers to link correctly. We should try and avoid this in the future.

Type of Change

API Impact

None.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.1%. Comparing base (40b4adc) to head (f7c169d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5028/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5028 +/- ## ========================================= - Coverage 71.1% 71.1% -0.0% ========================================= Files 796 796 Lines 66997 66997 Branches 10981 10980 -1 ========================================= - Hits 47638 47634 -4 - Misses 19359 19363 +4 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5028/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5028/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)