Open yinyiqian1 opened 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.3%. Comparing base (
ef02893
) to head (7cfe5b2
).:exclamation: Current head 7cfe5b2 differs from pull request most recent head bf284e7
Please upload reports for the commit bf284e7 to get more accurate results.
I'm wondering if this should be part of a new API version instead? @intelliot do you know if such API bug changes should introduce a new version or can we just change directly? (edit: nevermind i don't think it needs it since it's not breaking change)
Right - I see this as a bug fix. However, if we know with certainty that there are API consumers who will be broken by this change, then it would also be ok to put it on api_version 3. But currently, I don't think that is needed.
fix #4314
High Level Overview of Change
Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)