search

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.48k stars 1.44k forks source link

fixInnerObjTemplate2 amendment #5047

Closed scottschurr closed 1 day ago

scottschurr commented 2 weeks ago

High Level Overview of Change

Apply inner object templates to all remaining (non-AMM) inner objects.

Context of Change

It was discovered that the inner objects added to the code base for the AMM were not properly protected by their templates. That oversight was corrected by the fixInnerObjTemplate amendment.

An audit showed that there were additional inner objects that did not have their templates applied. This pull request applies templates to those additional inner objects.

Adds a unit test for applying the template to sfMajorities. Other remaining inner objects showed no problems having templates applied.

Type of Change

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.3%. Comparing base (ef02893) to head (80f0120).

:exclamation: Current head 80f0120 differs from pull request most recent head c6a0802

Please upload reports for the commit c6a0802 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5047/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5047 +/- ## ========================================= - Coverage 71.3% 71.3% -0.0% ========================================= Files 796 796 Lines 66987 66902 -85 Branches 10892 10866 -26 ========================================= - Hits 47793 47703 -90 - Misses 19194 19199 +5 ``` | [Files](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [src/ripple/app/ledger/Ledger.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Fledger%2FLedger.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvbGVkZ2VyL0xlZGdlci5jcHA=) | `75.4% <100.0%> (ø)` | | | [src/ripple/app/misc/impl/AMMUtils.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Fmisc%2Fimpl%2FAMMUtils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvbWlzYy9pbXBsL0FNTVV0aWxzLmNwcA==) | `99.4% <100.0%> (ø)` | | | [src/ripple/app/tx/impl/AMMVote.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Ftx%2Fimpl%2FAMMVote.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvdHgvaW1wbC9BTU1Wb3RlLmNwcA==) | `96.0% <100.0%> (ø)` | | | [src/ripple/app/tx/impl/SetSignerList.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Ftx%2Fimpl%2FSetSignerList.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvdHgvaW1wbC9TZXRTaWduZXJMaXN0LmNwcA==) | `91.2% <100.0%> (ø)` | | | [src/ripple/protocol/Feature.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Fprotocol%2FFeature.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9wcm90b2NvbC9GZWF0dXJlLmg=) | `100.0% <ø> (ø)` | | | [src/ripple/protocol/STObject.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Fprotocol%2FSTObject.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9wcm90b2NvbC9TVE9iamVjdC5o) | `92.4% <ø> (ø)` | | | [src/ripple/protocol/impl/Feature.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Fprotocol%2Fimpl%2FFeature.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9wcm90b2NvbC9pbXBsL0ZlYXR1cmUuY3Bw) | `94.6% <ø> (ø)` | | | [src/ripple/protocol/impl/STObject.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Fprotocol%2Fimpl%2FSTObject.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9wcm90b2NvbC9pbXBsL1NUT2JqZWN0LmNwcA==) | `85.3% <100.0%> (ø)` | | | [src/ripple/rpc/impl/TransactionSign.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Frpc%2Fimpl%2FTransactionSign.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9ycGMvaW1wbC9UcmFuc2FjdGlvblNpZ24uY3Bw) | `88.2% <100.0%> (ø)` | | | [src/ripple/app/tx/impl/Change.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&filepath=src%2Fripple%2Fapp%2Ftx%2Fimpl%2FChange.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9hcHAvdHgvaW1wbC9DaGFuZ2UuY3Bw) | `68.5% <75.0%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | | ... and [1581 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5047/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5047/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)
scottschurr commented 3 days ago

Thanks for the reviews! This PR needs to go through the physical restructure re-mapping process before it can be merged. So I'll do the remapping soon. Once that is done I'll mark the PR as passed.

scottschurr commented 3 days ago

The physical restructure is done. Unit tests, start, sync, and graceful stop all work on my Mac for both debug and release builds. The CI problem with coverage looks like a host thing. I'm marking this pull request passed.