XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.48k stars 1.44k forks source link

fix CTID in tx command returns invalidParams on lowercase hex #5049

Open yinyiqian1 opened 1 week ago

yinyiqian1 commented 1 week ago

fix #4776

High Level Overview of Change

Context of Change

Type of Change

API Impact

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.3%. Comparing base (c706926) to head (784059d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5049/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5049 +/- ## ======================================= Coverage 71.3% 71.3% ======================================= Files 796 796 Lines 66987 66987 Branches 10886 10866 -20 ======================================= + Hits 47765 47788 +23 + Misses 19222 19199 -23 ``` | [Files](https://app.codecov.io/gh/XRPLF/rippled/pull/5049?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [src/ripple/rpc/CTID.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5049?src=pr&el=tree&filepath=src%2Fripple%2Frpc%2FCTID.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3JpcHBsZS9ycGMvQ1RJRC5o) | `100.0% <100.0%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5049/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5049/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)