Open yinyiqian1 opened 4 weeks ago
Attention: Patch coverage is 48.30287%
with 198 lines
in your changes missing coverage. Please review.
Project coverage is 77.6%. Comparing base (
838978b
) to head (372cc5c
). Report is 1 commits behind head on develop.
🚨 Try these New Features:
PR description should be added with a link to technical specifications if applicable.
PR description should be added with a link to technical specifications if applicable.
just added
FYI: unit test failures are transient, which have passed locally. "ERR:Env Env::close() failed: no response from server"
spec: https://github.com/XRPLF/XRPL-Standards/discussions/217 https://github.com/XRPLF/XRPL-Standards/discussions/218
This PR includes the following changes:
more details:
account
andisDelegated
in PreflightContext, PreclaimContext and ApplyContext. Theaccount
is the account which is the transaction being operated on.account_
is updated to the account which is the transaction being operated on.gpSet
is added to ApplyContext. It contains the granular permissions enabled for that transaction. But if the transaction is fully delegated, then even there are granular permissions related to that transaction, the gpSet will be cleared up. To be more specific: a. isDelegated=true && gpSet not empty: only granular permissions delegated to the transaction b. isDelegated=true && gpSet is empty: the transaction is fully delegatedPermissions.cpp
are supported, so the unauthorized granular operations and the other parts under these transactions are prohibited under granular permission mode.High Level Overview of Change
Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)