Open ximinez opened 3 weeks ago
Attention: Patch coverage is 0%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 77.9%. Comparing base (
838978b
) to head (34d918a
).
Files with missing lines | Patch % | Lines |
---|---|---|
include/xrpl/server/detail/Door.h | 0.0% | 2 Missing :warning: |
@thejohnfreeman @vlntb I want to bring your attention to draft PR #5180. It builds on top of this PR, but adds three commits:
Env
tests cycle through a range of ports so that if the OS is slow to close a port when one test ends, the next test doesn't immediately try to open it. A general retry
operation is added so that lower-level network issues can also be retried, not just failed RPC commands.I would like to roll those changes into this PR so we can get the MacOS jobs fixed all in one shot. Do you think that's a good idea, or should that be a separate PR to be merged separately sometime after this one?
I don't see any approvals in here yet, so I say roll them into this PR.
High Level Overview of Change
Retry all failed RPC connections / commands in unit tests.
Context of Change
Follow up to #5120 (23991c9), which added a retry for submit commands. It improved MacOS test reliability, but other tests are failing now.
Type of Change