test: Add more test cases for Base58 parser

ximinez commented 3 weeks ago

High Level Overview of Change

Adds unit tests related to the AccountID handling updated in 2.2.1 (#5078)

Context of Change

2.2.1 was released without all of the relevant unit tests for reasons. This PR finally follows up on that and adds the tests.

(Also fixes an unused variable build warning on Release builds.)

Type of Change

[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (you added tests for code that already exists, or your new feature included in this PR)

ximinez commented 3 weeks ago

The final commit message should not include "NFTs". That function was an unintentional duplicate.

Also need to add @thejohnfreeman as a coauthor, since he wrote the original unit test.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.9%. Comparing base (838978b) to head (a7d0dd3).

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5174/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5174 +/- ## ========================================= - Coverage 77.9% 77.9% -0.0% ========================================= Files 782 782 Lines 66621 66619 -2 Branches 8161 8136 -25 ========================================= - Hits 51902 51899 -3 - Misses 14719 14720 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/XRPLF/rippled/pull/5174?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [include/xrpl/protocol/detail/b58\_utils.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5174?src=pr&el=tree&filepath=include%2Fxrpl%2Fprotocol%2Fdetail%2Fb58_utils.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL3Byb3RvY29sL2RldGFpbC9iNThfdXRpbHMuaA==) | `95.5% <ø> (-0.1%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5174/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5174/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)

ximinez commented 3 weeks ago

Proposed commit message:

 test: Add more test cases for Base58 parser (#5174)

---------
Co-authored-by: John Freeman <jfreeman08@gmail.com>

ximinez commented 2 weeks ago

Hold merging until after 2.3.0 final release.

XRPLF / rippled