XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.53k stars 1.47k forks source link

DRAFT Wip/5171 #5180

Closed ximinez closed 1 week ago

ximinez commented 2 weeks ago

High Level Overview of Change

Context of Change

Type of Change

API Impact

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (838978b) to head (7f74c46).

Files with missing lines Patch % Lines
include/xrpl/server/detail/Door.h 0.0% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5180/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5180 +/- ## ========================================= - Coverage 77.9% 77.9% -0.1% ========================================= Files 782 782 Lines 66621 66619 -2 Branches 8161 8161 ========================================= - Hits 51902 51863 -39 - Misses 14719 14756 +37 ``` | [Files with missing lines](https://app.codecov.io/gh/XRPLF/rippled/pull/5180?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [include/xrpl/server/detail/Door.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5180?src=pr&el=tree&filepath=include%2Fxrpl%2Fserver%2Fdetail%2FDoor.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL3NlcnZlci9kZXRhaWwvRG9vci5o) | `79.3% <0.0%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5180/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5180/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)
ximinez commented 1 week ago

Rolled into #5171