XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.53k stars 1.47k forks source link

Proposed 2.3.0-rc1 #5182

Closed ximinez closed 2 weeks ago

ximinez commented 2 weeks ago

High Level Overview of Change

This is a release candidate for the 2.3.0 release.

Highlights:

The base branch is release. All releases (including betas) go in release. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to both release and develop.

Context of Change

This introduces

Type of Change

API Impact

kennyzlei commented 2 weeks ago

@godexsoft can you check "libXRPL compatibility with Clio / Publish libXRPL" and verify if there is a Clio compatibility issue?

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 92.99553% with 47 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (1fbf8da) to head (9d58f11). Report is 21 commits behind head on release.

Files with missing lines Patch % Lines
src/libxrpl/protocol/STAmount.cpp 88.3% 20 Missing :warning:
src/libxrpl/protocol/STParsedJSON.cpp 64.7% 6 Missing :warning:
src/libxrpl/protocol/MPTIssue.cpp 86.7% 4 Missing :warning:
src/libxrpl/protocol/Rate2.cpp 50.0% 3 Missing :warning:
include/xrpl/protocol/Asset.h 95.0% 2 Missing :warning:
src/libxrpl/basics/MPTAmount.cpp 87.5% 2 Missing :warning:
src/libxrpl/beast/insight/NullCollector.cpp 50.0% 2 Missing :warning:
src/libxrpl/protocol/Asset.cpp 91.3% 2 Missing :warning:
src/libxrpl/protocol/STObject.cpp 0.0% 2 Missing :warning:
src/libxrpl/beast/utility/src/beast_Journal.cpp 50.0% 1 Missing :warning:
... and 3 more
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5182/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## release #5182 +/- ## ========================================= + Coverage 76.2% 77.9% +1.7% ========================================= Files 760 782 +22 Lines 61568 66616 +5048 Branches 8126 8161 +35 ========================================= + Hits 46909 51902 +4993 - Misses 14659 14714 +55 ``` | [Files with missing lines](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [include/xrpl/basics/Expected.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2FExpected.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9FeHBlY3RlZC5o) | `100.0% <100.0%> (ø)` | | | [include/xrpl/basics/FeeUnits.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2FFeeUnits.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9GZWVVbml0cy5o) | `90.4% <100.0%> (+0.3%)` | :arrow_up: | | [include/xrpl/basics/IOUAmount.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2FIOUAmount.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9JT1VBbW91bnQuaA==) | `100.0% <100.0%> (ø)` | | | [include/xrpl/basics/MPTAmount.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2FMPTAmount.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9NUFRBbW91bnQuaA==) | `100.0% <100.0%> (ø)` | | | [include/xrpl/basics/Number.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2FNumber.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9OdW1iZXIuaA==) | `100.0% <100.0%> (ø)` | | | [include/xrpl/basics/XRPAmount.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2FXRPAmount.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9YUlBBbW91bnQuaA==) | `98.8% <100.0%> (+<0.1%)` | :arrow_up: | | [include/xrpl/basics/base\_uint.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2Fbase_uint.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9iYXNlX3VpbnQuaA==) | `96.8% <100.0%> (+0.1%)` | :arrow_up: | | [include/xrpl/basics/safe\_cast.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2Fsafe_cast.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9zYWZlX2Nhc3QuaA==) | `81.8% <ø> (ø)` | | | [include/xrpl/basics/scope.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2Fscope.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9zY29wZS5o) | `100.0% <100.0%> (ø)` | | | [include/xrpl/basics/tagged\_integer.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2Ftagged_integer.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy90YWdnZWRfaW50ZWdlci5o) | `100.0% <100.0%> (ø)` | | | ... and [153 more](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | | ... and [444 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5182/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5182/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)
kennyzlei commented 2 weeks ago

@godexsoft can you check "libXRPL compatibility with Clio / Publish libXRPL" and verify if there is a Clio compatibility issue?

Rerunning "Check libXRPL compatibility with Clio / Publish libXRP" succeeded

ximinez commented 2 weeks ago

Superseded by #5183