codecov[bot]
commented
4 days ago Codecov Report
Attention: Patch coverage is 92.50000% with 6 lines in your changes missing coverage. Please review.
Project coverage is 77.9%. Comparing base (
0ec17b6) to head (6799369).
Additional details and impacted files
[](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5196 +/- ## ========================================= - Coverage 77.9% 77.9% -0.0% ========================================= Files 782 782 Lines 66622 66677 +55 Branches 8136 8156 +20 ========================================= + Hits 51902 51930 +28 - Misses 14720 14747 +27 ``` | [Files with missing lines](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [include/xrpl/basics/BasicConfig.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=include%2Fxrpl%2Fbasics%2FBasicConfig.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL2Jhc2ljcy9CYXNpY0NvbmZpZy5o) | `87.2% <ø> (ø)` | | | [include/xrpl/server/detail/ServerImpl.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=include%2Fxrpl%2Fserver%2Fdetail%2FServerImpl.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL3NlcnZlci9kZXRhaWwvU2VydmVySW1wbC5o) | `92.5% <100.0%> (+0.8%)` | :arrow_up: | | [src/libxrpl/basics/BasicConfig.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=src%2Flibxrpl%2Fbasics%2FBasicConfig.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL2xpYnhycGwvYmFzaWNzL0Jhc2ljQ29uZmlnLmNwcA==) | `89.6% <100.0%> (ø)` | | | [src/libxrpl/server/Port.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=src%2Flibxrpl%2Fserver%2FPort.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL2xpYnhycGwvc2VydmVyL1BvcnQuY3Bw) | `76.8% <100.0%> (+0.2%)` | :arrow_up: | | [src/xrpld/app/main/GRPCServer.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=src%2Fxrpld%2Fapp%2Fmain%2FGRPCServer.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL2FwcC9tYWluL0dSUENTZXJ2ZXIuaA==) | `100.0% <ø> (ø)` | | | [src/xrpld/overlay/detail/OverlayImpl.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=src%2Fxrpld%2Foverlay%2Fdetail%2FOverlayImpl.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL292ZXJsYXkvZGV0YWlsL092ZXJsYXlJbXBsLmNwcA==) | `34.7% <100.0%> (ø)` | | | [src/xrpld/rpc/ServerHandler.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=src%2Fxrpld%2Frpc%2FServerHandler.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL3JwYy9TZXJ2ZXJIYW5kbGVyLmg=) | `100.0% <100.0%> (ø)` | | | [src/xrpld/app/main/Application.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=src%2Fxrpld%2Fapp%2Fmain%2FApplication.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL2FwcC9tYWluL0FwcGxpY2F0aW9uLmNwcA==) | `69.3% <94.1%> (+0.4%)` | :arrow_up: | | [src/xrpld/app/main/GRPCServer.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=src%2Fxrpld%2Fapp%2Fmain%2FGRPCServer.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL2FwcC9tYWluL0dSUENTZXJ2ZXIuY3Bw) | `44.4% <93.3%> (+2.0%)` | :arrow_up: | | [src/xrpld/core/detail/Config.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&filepath=src%2Fxrpld%2Fcore%2Fdetail%2FConfig.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL2NvcmUvZGV0YWlsL0NvbmZpZy5jcHA=) | `74.2% <89.5%> (+0.7%)` | :arrow_up: | | ... and [1 more](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5196/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [](https://app.codecov.io/gh/XRPLF/rippled/pull/5196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)🚨 Try these New Features:
- Flaky Tests Detection - Detect and resolve failed and flaky tests
- JS Bundle Analysis - Avoid shipping oversized bundles
High Level Overview of Change
MACOS unit tests fix
Context of Change
Add retries to Env RPC requests to fix Macos disconnects during CI testing. RPC server use ip ports assigned by operating system automatically (instead of hard-coded) when unit tests run.
Type of Change
API Impact