Add MPTIssue to STIssue

[gregtatcam]

High Level Overview of Change

Replace Issue in STIssue with Asset. In this change, STIssue with MPTIssue is unused anywhere except in MPT tests. It is intended for use in Vault and in transactions with STIssue fields once MPT is integrated into DEX.

Type of Change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Refactor (non-breaking change that only restructures code)
• [ ] Performance (increase or change in throughput and/or latency)
• [x] Tests (you added tests for code that already exists, or your new feature included in this PR)
• [ ] Documentation update
• [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• [ ] Release

Test Plan

Extend MPTTest to test that AMMClawback, MMDeposit, AMMWithdraw, AMMDelete, AMMVote transactions don't support MPTIssue in Asset and Asset2.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 90.47619% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (0ec17b6) to head (8f3bbc4).

Files with missing lines	Patch %	Lines
include/xrpl/protocol/STIssue.h	72.7%	3 Missing :warning:
src/libxrpl/protocol/STIssue.cpp	91.4%	3 Missing :warning:
src/xrpld/app/ledger/OrderBookDB.cpp	0.0%	2 Missing :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5200 +/- ## ========================================= - Coverage 77.9% 77.9% -0.0% ========================================= Files 782 781 -1 Lines 66622 66652 +30 Branches 8136 8138 +2 ========================================= + Hits 51902 51924 +22 - Misses 14720 14728 +8 ``` | [Files with missing lines](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [include/xrpl/protocol/Asset.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=include%2Fxrpl%2Fprotocol%2FAsset.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL3Byb3RvY29sL0Fzc2V0Lmg=) | `95.0% <ø> (ø)` | | | [include/xrpl/protocol/Indexes.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=include%2Fxrpl%2Fprotocol%2FIndexes.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL3Byb3RvY29sL0luZGV4ZXMuaA==) | `100.0% <ø> (ø)` | | | [include/xrpl/protocol/SOTemplate.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=include%2Fxrpl%2Fprotocol%2FSOTemplate.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL3Byb3RvY29sL1NPVGVtcGxhdGUuaA==) | `96.8% <ø> (ø)` | | | [include/xrpl/protocol/STAmount.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=include%2Fxrpl%2Fprotocol%2FSTAmount.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL3Byb3RvY29sL1NUQW1vdW50Lmg=) | `95.1% <ø> (ø)` | | | [include/xrpl/protocol/STXChainBridge.h](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=include%2Fxrpl%2Fprotocol%2FSTXChainBridge.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL3Byb3RvY29sL1NUWENoYWluQnJpZGdlLmg=) | `97.7% <100.0%> (ø)` | | | [src/libxrpl/protocol/Indexes.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=src%2Flibxrpl%2Fprotocol%2FIndexes.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL2xpYnhycGwvcHJvdG9jb2wvSW5kZXhlcy5jcHA=) | `98.0% <100.0%> (+<0.1%)` | :arrow_up: | | [src/libxrpl/protocol/STTx.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=src%2Flibxrpl%2Fprotocol%2FSTTx.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL2xpYnhycGwvcHJvdG9jb2wvU1RUeC5jcHA=) | `86.9% <100.0%> (+0.1%)` | :arrow_up: | | [src/xrpld/app/misc/detail/AMMUtils.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=src%2Fxrpld%2Fapp%2Fmisc%2Fdetail%2FAMMUtils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL2FwcC9taXNjL2RldGFpbC9BTU1VdGlscy5jcHA=) | `99.4% <100.0%> (ø)` | | | [src/xrpld/app/tx/detail/AMMBid.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=src%2Fxrpld%2Fapp%2Ftx%2Fdetail%2FAMMBid.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL2FwcC90eC9kZXRhaWwvQU1NQmlkLmNwcA==) | `90.5% <100.0%> (+0.1%)` | :arrow_up: | | [src/xrpld/app/tx/detail/AMMClawback.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&filepath=src%2Fxrpld%2Fapp%2Ftx%2Fdetail%2FAMMClawback.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL2FwcC90eC9kZXRhaWwvQU1NQ2xhd2JhY2suY3Bw) | `100.0% <100.0%> (ø)` | | | ... and [8 more](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5200/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [](https://app.codecov.io/gh/XRPLF/rippled/pull/5200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles