XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.53k stars 1.47k forks source link

refactor: add `rpcName` to `LEDGER_ENTRY` macro #5202

Open mvadari opened 7 hours ago

mvadari commented 7 hours ago

High Level Overview of Change

The new LEDGER_ENTRY macro now takes one additional parameter, rpcName. This makes it easier to avoid missing including the new field in jss.h and to the list of account_objects/ledger_data filters.

Context of Change

Prevent easy bugs.

Type of Change

API Impact

No change to the user.

Test Plan

All tests still pass.

codecov[bot] commented 5 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.9%. Comparing base (0ec17b6) to head (5826d6f).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5202/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) ```diff @@ Coverage Diff @@ ## develop #5202 +/- ## ========================================= - Coverage 77.9% 77.9% -0.0% ========================================= Files 782 782 Lines 66622 66622 Branches 8136 8140 +4 ========================================= - Hits 51902 51894 -8 - Misses 14720 14728 +8 ``` | [Files with missing lines](https://app.codecov.io/gh/XRPLF/rippled/pull/5202?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) | Coverage Δ | | |---|---|---| | [include/xrpl/protocol/detail/ledger\_entries.macro](https://app.codecov.io/gh/XRPLF/rippled/pull/5202?src=pr&el=tree&filepath=include%2Fxrpl%2Fprotocol%2Fdetail%2Fledger_entries.macro&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-aW5jbHVkZS94cnBsL3Byb3RvY29sL2RldGFpbC9sZWRnZXJfZW50cmllcy5tYWNybw==) | `100.0% <100.0%> (ø)` | | | [src/libxrpl/protocol/LedgerFormats.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5202?src=pr&el=tree&filepath=src%2Flibxrpl%2Fprotocol%2FLedgerFormats.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL2xpYnhycGwvcHJvdG9jb2wvTGVkZ2VyRm9ybWF0cy5jcHA=) | `100.0% <ø> (ø)` | | | [src/xrpld/rpc/detail/RPCHelpers.cpp](https://app.codecov.io/gh/XRPLF/rippled/pull/5202?src=pr&el=tree&filepath=src%2Fxrpld%2Frpc%2Fdetail%2FRPCHelpers.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF#diff-c3JjL3hycGxkL3JwYy9kZXRhaWwvUlBDSGVscGVycy5jcHA=) | `82.8% <ø> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/XRPLF/rippled/pull/5202/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF) [![Impacted file tree graph](https://app.codecov.io/gh/XRPLF/rippled/pull/5202/graphs/tree.svg?width=650&height=150&src=pr&token=i2RPGI5xGF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)](https://app.codecov.io/gh/XRPLF/rippled/pull/5202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XRPLF)

🚨 Try these New Features: