search

XRPLF / xrpl-dev-portal

Source code for xrpl.org including developer documentation
https://xrpl.org
Other
519 stars 1.01k forks source link

NFTokenID in DirectoryNode is undocumented #1573

Open donovanhide opened 1 year ago

donovanhide commented 1 year ago

https://github.com/XRPLF/rippled/blob/1.9.4/src/ripple/protocol/impl/LedgerFormats.cpp#L74 https://xrpl.org/directorynode.html#directorynode-fields

mDuo13 commented 1 year ago

More detail on this:

The DirectoryNode docs need to be updated with changes that were part of XLS-20. Namely, there is now a third type of a directory: an NFT offer directory.

Each NFT now has up to two directories (each possibly consisting of multiple pages) to list NFTokenOffer objects to buy and sell that NFT. The DirectoryNode ledger entry type has new fields for this type, and possibly a new, third ID format.

The docs should add the new info and a new JSON example with an NFTokenOffer directory.