XRPLF / xrpl-dev-portal

Source code for xrpl.org including developer documentation
https://xrpl.org
Other
528 stars 1.02k forks source link

Document the convention for generating an Amendment ID #1761

Open intelliot opened 1 year ago

intelliot commented 1 year ago

This would be a good place for it: https://xrpl.org/amendments.html

By convention, it is the sha512half hash of the amendment name. https://github.com/xpring-eng/xrp-ledger-countdown/blob/e773351bfb0be282bfd950652a373f294f27965d/index.js#L50

kennyzlei commented 1 year ago

@intelliot your code link seems to point to a private github org, can you relink something that is public?

intelliot commented 1 year ago

Good catch. I searched for, and was not able to find, a public alternative. However, I reviewed the code linked, and I think it's OK to open source it. So I went ahead and made it public.

ckniffen commented 1 year ago

Also found here. https://github.com/ripple/explorer/blob/staging/src/containers/shared/amendmentUtils.ts