search

XRPLF / xrpl-dev-portal

Source code for xrpl.org including developer documentation
https://xrpl.org
Other
540 stars 1.02k forks source link

XRPFees Fields Reverted #1940

Closed jscottbranson closed 1 year ago

jscottbranson commented 1 year ago

I believe there are inconsistencies in the docs regarding the XRPFees amendment, since the amendment would have originally changed the field names to end in "Drops" (e.g., BaseFee vs BaseFeeDrops).

@mvadari pointed out that those changes were reverted in PR 4429 before the amendment was merged.

Thus, I believe the known amendment description needs to be updated as does the documentation on the SetFee fields.

ckniffen commented 1 year ago

Those field names were still changed. What didn't change was RPC calls and validation streams. If you are evaluating the SetFee transaction or looking at the FeeSettings ledger object and doing stuff with that then you will need to still update.

Since SetFee only is created during consensus we lowered the priority of updating the client libraries for it. The explorer has been update here. https://github.com/ripple/explorer/pull/605/files#diff-8c52e1cf259431d58ac697d339550d55477b537d7daddc3f9acc61dfd5c1715a.

Related issues: https://github.com/XRPLF/xrpl.js/issues/2219 https://github.com/XRPLF/xrpl-py/issues/526

ckniffen commented 1 year ago

I am working on adding the new types to the JS. One thing that was uncovered is clio does not work after this amendment is enabled. https://github.com/XRPLF/clio/issues/709