`terNO_LINE` and `terNO_RIPPLE` show incorrect explanations

XRPLF / xrpl-dev-portal

Source code for xrpl.org including developer documentation

https://xrpl.org

Other

528 stars 1.02k forks source link

`terNO_LINE` and `terNO_RIPPLE` show incorrect explanations #2546

Closed mvadari closed 2 months ago

mvadari commented 5 months ago

Page: https://xrpl.org/docs/references/protocol/transactions/transaction-results/ter-codes/#ter-codes

Both terNO_LINE and terNO_RIPPLE have this explanation:

Used internally only. This code should never be returned.

This is an incorrect explanation.

mDuo13 commented 5 months ago

I believe that the tec versions of these codes is normal but the ter version is not normally returned. A search of the rippled source implies this might be correct, but the total code path is unclear.

mvadari commented 5 months ago

I appear to have incorrectly extrapolated from one to the other - that does seem to be true for terNO_LINE, but not terNO_RIPPLE, which does seem to have legitimate code paths. Search link: https://github.com/search?q=repo%3AXRPLF%2Frippled+terNO_RIPPLE&type=code