search

XRPLF / xrpl-dev-portal

Source code for xrpl.org including developer documentation
https://xrpl.org
Other
525 stars 1.02k forks source link

Faucets page - rename faucetUrl to faucetHost #2725

Open mDuo13 opened 1 month ago

mDuo13 commented 1 month ago

It's not actually supposed to contain a URL, so that's confusing for maintenance every time we add a new faucet.

Modify https://github.com/XRPLF/xrpl-dev-portal/blob/master/resources/dev-tools/xrp-faucets.page.tsx and https://github.com/XRPLF/xrpl-dev-portal/blob/master/resources/dev-tools/faucets.json to change the faucetUrl field to be something more accurate, probably faucetHost.

Alternatively, we could modify it to actually take a URL.

mDuo13 commented 1 month ago

Also for some reason the spinner/loading animation that used to show while it's waiting to get your balance information isn't there anymore, and it would be nice to put that back.