search

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain
ISC License
144 stars 83 forks source link

Remove models for signing using a rippled server #223

Open mDuo13 opened 3 years ago

mDuo13 commented 3 years ago

The request models to sign a transaction using a rippled server are unnecessary and can be used unsafely. To reduce confusion, we should remove them. The rippled sign method is admin-only by default and deprecated anyway.

The following should be removed:

Furthermore, the model xrpl.models.requests.Submit should be an alias for xrpl.models.requests.SubmitOnly.

mvadari commented 2 years ago

Should these be deprecated first or just removed?