Add common field `ticket_sequence` to `Transaction`

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

144 stars 83 forks source link

Add common field `ticket_sequence` to `Transaction` #413

Closed LimpidCrypto closed 1 year ago

LimpidCrypto commented 2 years ago

The field ticket_sequence is missing as a common field in the Transaction object. It is needed to specify which ticket to be "replaced" with the transaction. Since no one complained so far, I guess it's not that urgent.

LimpidCrypto commented 2 years ago

I just saw the xrpl.js also does not has the field. Is that intended? Why is that?

JST5000 commented 2 years ago

I think xrpl.js does have the field here: https://github.com/XRPLF/xrpl.js/blob/aff6988f098ecc033a0cfa7974101f91de5cf948/packages/xrpl/src/models/transactions/common.ts#L156

The xrpl-py missing this value seems like an oversight. Started fixing it but didn't finish today.

LimpidCrypto commented 1 year ago

Resolved by #428