XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain
ISC License
144 stars 83 forks source link

feat: Remove `send_reliable_submission` #592

Closed JST5000 closed 1 year ago

JST5000 commented 1 year ago

High Level Overview of Change

Title says it all.

Context of Change

submit_and_wait now does everything send_reliable_submission does and more - so we want people to migrate to the new version which is receiving all our support.

Type of Change

Test Plan

CI Passes (I migrated over the tests which were only for send_reliable_submission to apply to submit_and_wait to keep that coverage)

JST5000 commented 1 year ago

Some of the snippets need to be fixed - they have an incorrect param order for submit_and_wait

Good catch - I thought I caught them all but the set_regular_key one had an incorrect order.