fix(test): move integration test out from unit tests

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

144 stars 83 forks source link

fix(test): move integration test out from unit tests #603

Closed mvadari closed 1 year ago

mvadari commented 1 year ago

High Level Overview of Change

There was an integration test that was in the unit test section. This PR moves that over.

Context of Change

The test was added in #520. I noticed that unit tests were suddenly taking much longer to run.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[x] Tests (You added tests for code that already exists, or your new feature included in this PR)

Test Plan

CI passes.

justinr1234 commented 1 year ago

@mvadari the diff seems weird?

mvadari commented 1 year ago

@mvadari the diff seems weird?

The diff is fine - I'm mainly moving the file from one folder to another, and moving a file doesn't have any diff. This is just a quick fix, so I didn't assimilate the tests into the existing ones (hence the TODO).

dangell7 commented 1 year ago

@mvadari These test are written to specific networks to get a specific network id response. Therefore we cannot use the IntegrationTestCase and must use an active network. This also means we cannot use WALLET because we need a wallet active on that specific network.

So I would like your opinion on what we should do?

@pdp2121 If you can elaborate at all please share. I tried to implement IntegrationTestCase without success.