feat: Add missing `nft_page`, `ledger_index` and `ledger_hash` fields to requests - Githubissues

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

144 stars 83 forks source link

feat: Add missing `nft_page`, `ledger_index` and `ledger_hash` fields to requests #604

Closed pdp2121 closed 1 year ago

pdp2121 commented 1 year ago

High Level Overview of Change

Add ledger_hash and ledger_index to account_nfts, nft_buy_offers, and nft_sell_offers requests.
Create LookupByLedgerRequest to clean up ledger_hash and ledger_index which are optional on most request objects.
Add nft_page to ledger_entry request.

Closes https://github.com/XRPLF/xrpl-py/issues/467

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Test Plan

Test passed.