Fix invalid account address

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

150 stars 84 forks source link

Fix invalid account address #611

Closed JST5000 closed 1 year ago

JST5000 commented 1 year ago

High Level Overview of Change

Update the test on master which was failing due to an invalid address which was passing silently incorrectly.

Context of Change

Originally found as a result of the behavior changing in rippled 1.11 - it now throws invalidAccount as expected on that version.

Type of Change

[X] Tests (You added tests for code that already exists, or your new feature included in this PR)

Test Plan

CI Passes

ckniffen commented 1 year ago

Since they are different there should be a malformed address test still.

JST5000 commented 1 year ago

I changed this PR to point at the 2.0 branch because the 2.0 branch already has a similar, but slightly worse, change in place, and if this were to be committed against master it'd create a merge conflict which may require a rebase to fix. Since this is all going to master anyway and is just a test, I think it's easier to just fix it all with the 2.0 merge.