XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain
ISC License
150 stars 84 forks source link

[2.0] `classic_address` isn't typed properly #616

Closed mvadari closed 1 year ago

mvadari commented 1 year ago

image

It looks like property aliases aren't supported in mypy right now: https://github.com/python/mypy/issues/6700

The best solution is likely to just copy-paste the address code, with a TODO for when mypy has resolved the issue.

JST5000 commented 1 year ago

For people encountering this issue before the next release, if you change from .classic_address to .address the issue goes away.

ckniffen commented 1 year ago

Closed by #617