XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain
ISC License
150 stars 84 forks source link

fix: Fix `classic_address` aliasing issue #617

Closed JST5000 closed 1 year ago

JST5000 commented 1 year ago

High Level Overview of Change

Fix mypy complaining about Wallet.classic_address being a Callable when it is an aliased str property. (Open mypy issue: https://github.com/python/mypy/issues/6700)

Context of Change

Currently aliasing a property is not properly typed by mypy. As a workaround you can switch to using address instead of classic_address, but this should resolve the issue until the mypy issue is fixed.

Type of Change

Test Plan

CI passes

JST5000 commented 1 year ago

Closes https://github.com/XRPLF/xrpl-py/issues/616