XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain
ISC License
150 stars 86 forks source link

fix: remove unnecessary parameters from LedgerClosed request #628

Closed jungsooyun closed 1 year ago

jungsooyun commented 1 year ago

High Level Overview of Change

This PR removes unnecessary parameters (ledger_hash and ledger_index) from the LedgerClosed model. (actually, ledger_hash and ledger_index field is for Response, not Request)

Context of Change

During a recent code review, it was discovered that the LedgerClosed model contained parameters that were not required in actual API (https://xrpl.org/ledger_closed.html)

Type of Change

Test Plan

CI Passes