XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain
ISC License
145 stars 83 forks source link

Add better error message for inputting `wallet` instead of `wallet.address` #644

Closed mvadari closed 9 months ago

mvadari commented 9 months ago

When someone accidentally creates a transaction object using account = wallet instead of account = wallet.address, the error is really difficult to debug:

AttributeError: 'Wallet' object has no attribute 'rstrip'

A better error message that catches this at the object level (perhaps another validation check) would make this easier to debug.

Zia-ullah-khan commented 9 months ago

I have been trying to figure this out for hours lol the error it gives is so vauge that I could not even belive that could be an error but you help me man thanks