fix: export `get_nftoken_id` and `parse_nftoken_id`, better error handling - Githubissues

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

150 stars 84 forks source link

fix: export `get_nftoken_id` and `parse_nftoken_id`, better error handling #646

Closed mvadari closed 1 year ago

mvadari commented 1 year ago

High Level Overview of Change

This PR:

Exports get_nftoken_id and parse_nftoken_id at the xrpl.utils level
Adds better error handling to get_nftoken_id if a metadata for an unrelated transaction is accidentally passed in

Context of Change

Noticed while working on #417

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)

Did you update CHANGELOG.md?

[x] Yes

Test Plan

Added a test.