Open LimpidCrypto opened 8 months ago
One potential issue: the
ledger_entry
request file also contains a bunch of classes with the same names as these objects.
I don't think it's an issue since they're differentiated by import paths.
One potential issue: the
ledger_entry
request file also contains a bunch of classes with the same names as these objects.I don't think it's an issue since they're differentiated by import paths.
They are, but if you're using both it can still get confusing.
One potential issue: the
ledger_entry
request file also contains a bunch of classes with the same names as these objects.I don't think it's an issue since they're differentiated by import paths.
They are, but if you're using both it can still get confusing.
Thoughts on adding prefix/postfix to the ledger object class names?
@khancode this PR should also add support for the fixPreviousTxnID
amendment, which was added in rippled 2.2.0.
@khancode this PR should also add support for the
fixPreviousTxnID
amendment, which was added in rippled 2.2.0.
Update: this PR is deprioritized and I'm no longer working on it. Feel free to pick it up or anyone else.
High Level Overview of Change
This PR adds (some) Ledger Object models:
You might want to look over the fields if they are still correct as it's been a while since I wrote them.
TODO
MD...
models to metadata PR (see #664)Context of Change
@JST5000 and I had a great chat this week. He told me one thing you might prioritize as a coming feature would be response models. I remembered I once had a PR adding Ledger Object and Metadata models and was told to split it up into two PRs, but somehow I forgot about it. This PR adds the Ledger objects. I could imagine there are some objects missing or are a bit deprecated but I still wanted to leave the progress made here for you to use.
Type of Change
Did you update CHANGELOG.md?
Test Plan
I wrote tests trying to de-/serialize them from/to json.