[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release
Did you update CHANGELOG.md?
[ ] Yes
[x] No, this change does not impact library users
This PR improves the handling of the faucet URL. I'm not sure if it needs to be included in the CHANGELOG. The changes are intuitive.
Test Plan
Some unit tests have been added to validate this change.
Many thanks to @justinr1234 for coming up with the design and code for this solution
jonathanlei
commented
6 months ago
High Level Overview of Change
This PR seeks to address https://github.com/XRPLF/xrpl-py/issues/364
This is an alternative approach competing with https://github.com/XRPLF/xrpl-py/pull/676 PR #676 needs to be closed after this PR is reviewed and merged.
Context of Change
Type of Change
Did you update CHANGELOG.md?
Test Plan
Some unit tests have been added to validate this change.
Many thanks to @justinr1234 for coming up with the design and code for this solution