Rectify flag name TF_NO_RIPPLE_DIRECT - Githubissues

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

150 stars 84 forks source link

Rectify flag name TF_NO_RIPPLE_DIRECT #691

Closed ckeshava closed 6 months ago

ckeshava commented 7 months ago

High Level Overview of Change

Rectify the incorrect usage of the transaction flag from TF_NO_DIRECT_RIPPLE to TF_NO_RIPPLE_DIRECT

Context of Change

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Did you update CHANGELOG.md?

[x] Yes
[ ] No, this change does not impact library users

Test Plan

Updated the tests to use the new flag name

pdp2121 commented 7 months ago

Is it also a breaking change? If so, please reflect on CHANGELOG

ckeshava commented 7 months ago

Hello @pdp2121 , I have included a line in the CHANGELOG. Do you want me to re-word that?