XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain
ISC License
144 stars 83 forks source link

Add nfts_by_issuer data type #707

Closed Kassaking7 closed 3 weeks ago

Kassaking7 commented 1 month ago

High Level Overview of Change

Title

Context of Change

Following https://ripplelabs.atlassian.net/jira/software/projects/DEFI/boards/760?assignee=712020%3Aff4deb34-7fc1-428e-a2ee-354e1ddba309&selectedIssue=DEFI-128 & https://xrpl.org/docs/references/http-websocket-apis/public-api-methods/clio-methods/nfts_by_issuer/

Type of Change

Did you update CHANGELOG.md?

Test Plan

Kassaking7 commented 1 month ago

Seems not require test cases since the lib currently doesn't support integration test for Clio

shawnxie999 commented 1 month ago

You are missing some changes. You can take a look at how the nft_history API is done. Do global search to find NFT_HISTORY and NFTHistory, and see where you are missing in some of the places.