feat: add input check for OracleSet params AssetPrice and Scale - Githubissues

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

150 stars 84 forks source link

feat: add input check for OracleSet params AssetPrice and Scale #711

Closed anissa-ripple closed 4 months ago

anissa-ripple commented 4 months ago

High Level Overview of Change

Context of Change

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Did you update CHANGELOG.md?

[ ] Yes
[x] No, this change does not impact library users

Test Plan

anissa-ripple commented 4 months ago

I removed the nested model validation since that is covered by @mvadari 's PR here https://github.com/XRPLF/xrpl-py/pull/708