[FIX] Issue #709: do not enqueue all responses

[ckeshava]

High Level Overview of Change

Do not enqueue messages that correspond to an existing request

Context of Change

Bug Fix: At the moment, we are enqueuing all the incoming messages.

Type of Change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Refactor (non-breaking change that only restructures code)
• [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
• [ ] Documentation Updates
• [ ] Release

Did you update CHANGELOG.md?

• [ ] Yes
• [ ] No, this change does not impact library users This change impacts the memory usage of the system, hence is not directly perceivable by end users.

[ckeshava]

I'm not able to find requests which increase the queue size

class TestWebSocketClient(TestCase):
    """Performace test of the async web_socket_client."""

    def test_web_socket_client(self: TestWebSocketClient) -> None:
        URL = "wss://s.devnet.rippletest.net:51233"

        with WebsocketClient(URL) as client:
            pendings_msg_size = []

            for _ in range(100):
                client.request(ServerInfo())
                pendings_msg_size.append(len(client._open_requests))

            print(max(pendings_msg_size)) # returns 0

[mvadari]

I'm not able to find requests which increase the queue size

class TestWebSocketClient(TestCase):
    """Performace test of the async web_socket_client."""

    def test_web_socket_client(self: TestWebSocketClient) -> None:
        URL = "wss://s.devnet.rippletest.net:51233"

        with WebsocketClient(URL) as client:
            pendings_msg_size = []

            for _ in range(100):
                client.request(ServerInfo())
                pendings_msg_size.append(len(client._open_requests))

            print(max(pendings_msg_size)) # returns 0

Try client._messages instead of client._open_requests.

[ckeshava]

_messages

client._messages has a qsize of 0

[mvadari]

How did you test this change? If not by adding a test case, then what?

[ckeshava]

I don't have a good idea to test this change. But irrespective of the impact on this issue, I think this change is useful.

I don't know which inputs would reproduce the issue description.