[Fix #710] Use network_id to identify faucet_url - Githubissues

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

151 stars 86 forks source link

[Fix #710] Use network_id to identify faucet_url #715

Open ckeshava opened 5 months ago

ckeshava commented 5 months ago

High Level Overview of Change

use network_id to disambiguate between different XRPL chains
move the utility function _get_network_id_and_build_version into client.py file for convinience

Context of Change

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[x] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Did you update CHANGELOG.md?

[ ] Yes
[x] No, this change does not impact library users This change should not modify the experience for external developers

Test Plan

Tests have been modified to accomodate the new API for grabbing the faucet_url