Empty strings in DIDSet transaction - Githubissues

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

150 stars 84 forks source link

Empty strings in DIDSet transaction #717

Closed ckeshava closed 3 months ago

ckeshava commented 3 months ago

High Level Overview of Change

Fix https://github.com/XRPLF/xrpl-py/issues/716

Context of Change

Fields within a DID object can only be deleted by setting an empty string. However, the regex in the DIDSet model do not account for empty strings.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Did you update CHANGELOG.md?

[x] Yes
[ ] No, this change does not impact library users

Test Plan

Unit tests have been added to this effect

ckeshava commented 3 months ago

I have reverted back to an older commit. I removed the integration test and restored the unit test. Let me know if this looks ok